Dear Weasel
|
Author |
Message |
'www.rombarded.com'
Member Lvl: 70
Egg Points: 317721
Posts: 12836
|
| Posted: Jun 14, 2008 7:32 p.m. - Subject: Dear Weasel |
| |
http://www.rotteneggs.com/r/layout/js/starbar_v2.js
Quote Variable Declaration: var STARBAR_NI_VALUE = -1;
Quote Boolean Qualifier: if (whichStar == STARBAR_NI_VALUE) {
rateHref = "&movieid="+itemId+"&value="+"norec";
StarbarTypes[imgNum] = STARBAR_TYPE_EMPTY;
StarbarNumStars[imgNum] = StarbarPredictions[imgNum];
StarbarSpecialValues[imgNum] = whichStar;
Quote Vote Link: javascript:StarbarClick(-1,’RANDOM HASH’);
There, now will you please fix the zero star? I really don’t feel like screwing around in Greasemonkey for the rest of the weekend to create a patch (yes, it’s possible; no, I’m not going to).
Also, there’s a really useless XSS hole in the voting system, you’d practically have to tell someone to paste javascript into their URL bar twice for it to ever doing anything, but here’s a screenshot.
|
Master Egg
Member Lvl: 50
Egg Points: 902451
Posts: 5655
AIM
|
| Posted: Jun 14, 2008 7:37 p.m. - Subject: |
| |
cool
|
'www.rombarded.com'
Member Lvl: 70
Egg Points: 317721
Posts: 12836
|
| Posted: Jun 14, 2008 7:41 p.m. - Subject: |
| |
Basically, I’m pretty sure you can just change the STARBAR_NI_VALUE variable to 0 instead of -1 to make the zero star work. I could be wrong, but trial-and-error has never failed me.
|
Master Egg
Member Lvl: 50
Egg Points: 902451
Posts: 5655
AIM
|
| Posted: Jun 14, 2008 7:45 p.m. - Subject: |
| |
cody you act like you’re hot shit cause you know all this stuff.... well let me tell you something.... YOU AREN’T
:D
And you’re gay
:D :D
|
Normal Egg
Member Lvl: 9
Egg Points: 29286
Posts: 2564
AIM YIM
|
| Posted: Jun 14, 2008 7:48 p.m. - Subject: |
| |
Would it really be that time-consuming to change any -1’s to 0’s?
|
'www.rombarded.com'
Member Lvl: 70
Egg Points: 317721
Posts: 12836
|
| Posted: Jun 14, 2008 7:52 p.m. - Subject: |
| |
Well, for one, I’m not entirely sure if this is the problem or not, but that would explain why voting a 0 (-1) gives a norec value in the url, and why voting a 0 (0) gives a 0 value, but doesn’t save anything.
Also, in order to patch it in greasemonkey, I’d have to add all that code to the source, then redo the frontend of the voting system. I really don’t feel like doing that.
|
Power Egg
Member Lvl: 20
Egg Points: 759673
Posts: 5498
|
| Posted: Jun 14, 2008 7:52 p.m. - Subject: |
| |
OI!
why ME?!
though sweet.
it’s nice having someone around that does more work then monir ever will. (cause THAT narrows it down LOL)
|
'NOTICE BOT IS NOTICE'
Forum Moderator
Member Lvl: 65
Egg Points: 486294
Posts: 13722
AIM YIM
|
| Posted: Jun 14, 2008 7:54 p.m. - Subject: |
| |
nice AE, good job
|
'www.rombarded.com'
Member Lvl: 70
Egg Points: 317721
Posts: 12836
|
| Posted: Jun 14, 2008 7:57 p.m. - Subject: |
| |
I’m attempting to figure out if I can vote 0*s without weasel’s intervention.
|
'NOTICE BOT IS NOTICE'
Forum Moderator
Member Lvl: 65
Egg Points: 486294
Posts: 13722
AIM YIM
|
| Posted: Jun 14, 2008 7:59 p.m. - Subject: |
| |
that would be intense
|
Power Egg
Member Lvl: 10
Egg Points: 16385
Posts: 1373
AIM
|
| Posted: Jun 14, 2008 8:01 p.m. - Subject: |
| |
Weasel is inactive and I highly doubt he will adress this or any of the other issues of this site. NIce job though.
|
'NOTICE BOT IS NOTICE'
Forum Moderator
Member Lvl: 65
Egg Points: 486294
Posts: 13722
AIM YIM
|
| Posted: Jun 14, 2008 8:02 p.m. - Subject: |
| |
it will be done before Cthullu rises
|
Power Egg
Member Lvl: 10
Egg Points: 16385
Posts: 1373
AIM
|
| Posted: Jun 14, 2008 8:05 p.m. - Subject: |
| |
Don’t look behind you...
|
'The Overlord'
Egg Moderator
Member Lvl: 77
Egg Points: 953450
Posts: 6254
|
| Posted: Jun 14, 2008 8:07 p.m. - Subject: |
| |
The -1 has always been there.
|
'www.rombarded.com'
Member Lvl: 70
Egg Points: 317721
Posts: 12836
|
| Posted: Jun 14, 2008 8:13 p.m. - Subject: |
| |
Quote: The -1 has always been there.
Yes, the -1 in the vote link has. But if you look in the js file, there’s a condition for if the vote value is -1, to put ’norec’ in place of the vote value, which would cause 0* (-1) votes to not register. So by fixing this condition (either changing the variable it’s checking or removing the condition all together), it should, in theory, work again.
|
Normal Egg
Member Lvl: 8
Egg Points: 188
Posts: 1185
AIM
|
| Posted: Jun 14, 2008 8:24 p.m. - Subject: |
| |
Wow you kick ass
|
'The Overlord'
Egg Moderator
Member Lvl: 77
Egg Points: 953450
Posts: 6254
|
| Posted: Jun 14, 2008 8:31 p.m. - Subject: |
| |
That’s interesting. It’s also interesting that you can put, say, 5-6, in place of the vote value and it does the math. That shouldn’t surprise me but it does.
|
'www.rombarded.com'
Member Lvl: 70
Egg Points: 317721
Posts: 12836
|
| Posted: Jun 14, 2008 8:42 p.m. - Subject: |
| |
oh, if that link doesn’t work, copy paste this:
http://www.rotteneggs.com/r/layout/javascript/starbar_v2.js
|
Power Egg
Member Lvl: 12
Egg Points: 3629
Posts: 1065
YIM
|
| Posted: Jun 14, 2008 8:47 p.m. - Subject: |
| |
so if we use ’-3’ we can clear our vote and revote?
|
'www.rombarded.com'
Member Lvl: 70
Egg Points: 317721
Posts: 12836
|
| Posted: Jun 14, 2008 8:52 p.m. - Subject: |
| |
I don’t think that works, I recall trying it once. I’m pretty sure weasel jacked the source for the rating system from a free 5cript then edited it to work with the site, so a lot of that code doesn’t even do anything.
|
|
|
